Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tests badge in readme #430

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

update tests badge in readme #430

wants to merge 2 commits into from

Conversation

Borda
Copy link

@Borda Borda commented Jan 16, 2024

Seems Travis testing was dropped some time ago, but the badge still refers to it instead of newly/actually used GitHub actions. Compared to #415, it links to the already existing CI workflows without any other changes... 🦩

cc: @bndr

@Borda
Copy link
Author

Borda commented Jan 19, 2024

@bndr, would you mind approving the CI run to validate the suggested fix?

@alan-barzilay alan-barzilay changed the base branch from master to next February 18, 2024 15:40
@alan-barzilay alan-barzilay deleted the branch bndr:next February 18, 2024 18:17
@Borda Borda deleted the readme/badge branch February 19, 2024 20:10
@Borda
Copy link
Author

Borda commented Feb 19, 2024

@alan-barzilay, I'm wondering what I did wrong that this was just closed? 😕
as it is still broken on the next branch...

@alan-barzilay
Copy link
Collaborator

oops, my bad. When I made the new release I deleted the next branch and then created it again to make sure it was compatible with master (had some weird conflicts).
Since I had switched the target of your PR to the next branch, it was automatically closed by github when I deleted the branch.

I cant reopen it since now you deleted the readme/badge branch haha you are welcome to reopen it or make a new PR, but I'm not sure I will be working any further in this project. If that happens there won't be anyone to approve your PR, since this repo is pretty much abandoned (I can't get in touch with the repo creator and its really hard to manage this alone without sufficient repo permissions/powers).

thank you for your contribution and sorry for the mishap.

@Borda Borda restored the readme/badge branch February 19, 2024 21:51
@Borda
Copy link
Author

Borda commented Feb 19, 2024

I cant reopen it since now you deleted the readme/badge branch

@alan-barzilay just restored the branch

@alan-barzilay alan-barzilay reopened this Feb 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68f9b28) 89.96% compared to head (e4faec2) 91.56%.
Report is 26 commits behind head on next.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #430      +/-   ##
==========================================
+ Coverage   89.96%   91.56%   +1.60%     
==========================================
  Files           2        2              
  Lines         259      415     +156     
==========================================
+ Hits          233      380     +147     
- Misses         26       35       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Borda
Copy link
Author

Borda commented Feb 27, 2024

@alan-barzilay is all good here? 🐰

@Borda
Copy link
Author

Borda commented Aug 14, 2024

friendly ping @alan-barzilay 🐿️

mind have a look, when you have time 🦩

@Borda
Copy link
Author

Borda commented Nov 12, 2024

friendly ping @alan-barzilay 🐿️

mind have a look, when you have time 🦩

hello, would you pls have a moment to check this PR 🐰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants