tester: Use CompositeClassLoader for TCCL when loading tests #5743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class can be used to composite multiple class loaders to search in sequence for a class or resource. Signed-off-by: BJ Hargrave <[email protected]>
We use CompositeClassLoader to composite the tester bundle's class loader with the original TCCL when loading and executing tests. This will provide visibility classes and resource from the original TCCL. Fixes bndtools#5568 Signed-off-by: BJ Hargrave <[email protected]>
|
Before we go down this path I want to revisit 859636b and see if it (or this) was really necessary, because I don't think that they should be. I've backed out that change in my local commit and I can see that it causes the tests to fail, but I think that these failures might be due to the isolation between the Eclipse launcher and the Launchpad system-under-test. |
kriegfrj
added a commit
that referenced
this pull request
Aug 9, 2023
This is an alternative fix for #5568 which supersedes commit bef0458 in PR #5743. We minimise the scope of the TCCL change so that it does not interfere with the (otherwise working) default classloader mechanisms during test execution. Fixes #5568. Signed-off-by: Fr Jeremy Krieg <[email protected]>
|
Referr #5744 for the follow-up, alternate solution that superseded this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use CompositeClassLoader to composite the tester bundle's class
loader with the original TCCL when loading and executing tests. This
will provide visibility classes and resource from the original TCCL.
Fixes #5568