Improve repo tagging #6343
Merged
Improve repo tagging #6343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrueger
commented
Oct 30, 2024
|
@pkriens condition improved and Glob support added. |
pkriens
reviewed
Oct 30, 2024
chrisrueger
force-pushed
the
improve-repo-tags
branch
from
9836d5a
to
b0ef3be
Compare
|
LGTM! lets merge this baby! |
This does not show 'resolve' on all repos in the Repo Browser anymore Signed-off-by: Christoph Rueger <[email protected]>
it is still possible there are custom Repository plugins which do not implement the Tagged interface yet. those repositories should still be considered for resolving Signed-off-by: Christoph Rueger <[email protected]> improve readability of condition and wording Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]>
as suggested javadoc Signed-off-by: Christoph Rueger <[email protected]>
chrisrueger
force-pushed
the
improve-repo-tags
branch
from
b0ef3be
to
2688cb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @pkriens today:
Also fixed a bug I discovered regarding Repository implementations which currently do not implement the
Taggedinterface. Those repositories should still be considered for resolution by default (as if they have theresolvetag). This is e.g. the case for any custom Respository plugin in the wild whichimplements Repositorybut not Tagged (because Tagged interface is just being added in 7.1.0)