Add tests #34

mzbik · 2020-08-22T04:31:41Z

Ben - this PR does:

Minimal change to CMakeLists.txt to enable tests being built. It adds COMPILE_TEST as a variable to enable/disable compilation of tests
All test CMake-related stuff is in a subdir CMakeTests
This builds unittests, cctest, and cppgc_unittests all of which pass
Requires no other PR

…BUILD.gn) 2. Small change to unify the disable-exception-defines

…eLists.txt

…_compiler Adds initializers to link path

Adds configs back. Way simpler to handle common sets of built parameters.

Note: to run successfully, you'll need to add --timeout=2000 to the cctest invocation (via tools/run-tests.py) as well as increase the default macos pthread stack size (the compiler is now using more space).

…ests

…n terms of linker search rules for resolving symbols in libraries. Prior to this change, v8_base_without_compiler referenced v8_inspector AND v8_inspector referenced v8_base_without_compiler. GNU ld would do a search and not resolve symbols. Including the inspector object files as part of v8_base_without_compiler addresses this

mzbik added 18 commits July 31, 2020 12:18

Simplifies torque output positioning

7a9d1e4

1. Collects common includes into one variable (matches what is in v8/…

5e7ecd8

…BUILD.gn) 2. Small change to unify the disable-exception-defines

Adds test .cmake directory and files. This is to reduce churn in CMak…

74688fc

…eLists.txt

Add third_party_google test targets

f1a2ae3

Adds v8/testing/gtest

06bb94c

Adds v8/testing/gmock

1590e5e

Adds wasm_test_common target

a86b855

Adds v8/wasm_module_runner target

d2a7cf0

Adds cctest. cctest runs no tests yet.

93ff9f2

Makes v8_inspector available to targets that refer to v8_base_without…

f332045

…_compiler Adds initializers to link path

Adds unittests. Unittests run successfully.

9bde97e

Adds zlib.

a99168a

Adds configs back. Way simpler to handle common sets of built parameters.

Adds cppgc tests. All pass.

a2c86f8

Makes cctest build completely and run

8a40806

Note: to run successfully, you'll need to add --timeout=2000 to the cctest invocation (via tools/run-tests.py) as well as increase the default macos pthread stack size (the compiler is now using more space).

Merge branch 'master' into add-tests

52b077d

Adds variable COMPILE_TESTS to factor out building v8 from building t…

6598ff5

…ests

Fix Windows build; make sure X86_WINDOWS is defined in zlib

a0158a2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests #34

Add tests #34

mzbik commented Aug 22, 2020 •

edited

Loading

Add tests #34

Are you sure you want to change the base?

Add tests #34

Conversation

mzbik commented Aug 22, 2020 • edited Loading

mzbik commented Aug 22, 2020 •

edited

Loading