Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Number.prototype.toExponential() #4177

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix Number.prototype.toExponential() #4177

wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

This Pull Request fixes/closes #4169

This PR uses the draft PR in boa-dev/ryu-js#50. Once the upstream PR is finished and merge will release a new version of ryu-js and update this PR.

Now we have all test262 built-in Number tests passing!! 🥳

@HalidOdat HalidOdat added the bug Something isn't working label Feb 24, 2025
@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 46,451 46,452 +1
Ignored 1,634 1,634 0
Failed 2,169 2,168 -1
Panics 0 0 0
Conformance 92.43% 92.43% +0.00%
Fixed tests (1): 
test/built-ins/Number/prototype/toExponential/return-values.js (previously Failed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Number.prototype.toExponential() value rounding
1 participant
@HalidOdat