Fixing FindBugs warnings and bumping version numbers to 2.5.3

bobbylight · Jun 29, 2014 · 51f242c · 51f242c
1 parent cfd330e
commit 51f242c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/build.xml b/build.xml
@@ -23,7 +23,7 @@
 
 
 	<!-- Set global properties for this build. -->
-	<property name="version"          value="2.5.2"/>
+	<property name="version"          value="2.5.3"/>
 	<property name="source-dir"       location="src"/>
 	<property name="class-dir"        location="ant-classes"/>
 	<property name="dist-dir"         location="dist"/>

diff --git a/src/org/fife/rsta/ui/AssistanceIconPanel.java b/src/org/fife/rsta/ui/AssistanceIconPanel.java
@@ -108,7 +108,7 @@ public void propertyChange(PropertyChangeEvent e) {
 	 *        is not currently available.
 	 */
 	public void setAssistanceEnabled(Image img) {
-		if (img==null && getIcon()!=EMPTY_ICON) {
+		if (img==null) {
 			setIcon(EMPTY_ICON);
 			setToolTipText(null);
 		}

diff --git a/src/org/fife/rsta/ui/demo/RSTAUIDemoApp.java b/src/org/fife/rsta/ui/demo/RSTAUIDemoApp.java
@@ -160,6 +160,7 @@ public void searchEvent(SearchEvent e) {
 		SearchResult result = null;
 
 		switch (type) {
+			default: // Prevent FindBugs warning later
 			case MARK_ALL:
 				result = SearchEngine.markAll(textArea, context);
 				break;