Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix #546: Better word wrap for plain text #558

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bobbylight
Copy link
Owner

@bobbylight bobbylight commented Jul 6, 2024

Proposed fix for #546. Use BreakIterator in PlainTextTokenMaker to ensure line wrapping is done in a per-locale, language-specific basis.

Remaining issues:

  • Mark Occurrences marks tokens as identified, which isn't logical to users (tokens area identified based on where line breaks can occur, so stuff like foo). is marked as a single token). We'll need to either disable Mark Occurrences for plain text, or create a custom PlainTextOccurrenceMarker that looks for e.g. strings of letters within tokens (which might be very very slow).
  • Would need to delete PlainTextTokenMaker.flex, as PlainTextTokenMaker.java is now a hand-written TokenMaker.

@bobbylight bobbylight changed the title WIP: Better word wrap for plain text WIP: fix #546: Better word wrap for plain text Jul 6, 2024
@bobbylight bobbylight force-pushed the fix-546-better-wrapping-for-plain-text branch 2 times, most recently from 01f48ba to 54c8623 Compare November 30, 2024 14:03
@bobbylight bobbylight force-pushed the fix-546-better-wrapping-for-plain-text branch from 54c8623 to 9ed9526 Compare December 8, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant