generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for auto_merge
and required_contexts
#152
Open
gjtorikian
wants to merge
8
commits into
bobheadxi:main
Choose a base branch
from
gjtorikian:support-more-deployments-logic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for auto_merge
and required_contexts
#152
gjtorikian
wants to merge
8
commits into
bobheadxi:main
from
gjtorikian:support-more-deployments-logic
+39
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjtorikian
force-pushed
the
support-more-deployments-logic
branch
8 times, most recently
from
June 28, 2023 18:36
488ebbe
to
f257800
Compare
gjtorikian
force-pushed
the
support-more-deployments-logic
branch
2 times, most recently
from
June 28, 2023 19:19
95c1256
to
962f8a1
Compare
gjtorikian
force-pushed
the
support-more-deployments-logic
branch
from
June 28, 2023 19:22
962f8a1
to
d8b71ed
Compare
I had to change the
|
halostatue
added a commit
to KineticCafe/deployments
that referenced
this pull request
Feb 29, 2024
Changes were made to make the values cleaner and fix some incorrect assumptions.
halostatue
added a commit
to KineticCafe/deployments
that referenced
this pull request
Mar 4, 2024
Changes were made to make the values cleaner and fix some incorrect assumptions.
halostatue
added a commit
to KineticCafe/deployments
that referenced
this pull request
Mar 11, 2024
Adopted bobheadxi/deployments as KineticCafe/deployments, mostly to use Node 20 as required by GitHub. ```diff - uses: bobheadxi/deployments@v1 + uses: KineticCafe/deployments@v1 ``` We recommend using a more specific version tag: ```diff - uses: bobheadxi/deployments@v1 + uses: KineticCafe/[email protected] ``` - Switch from `npm` to `pnpm` - Switch from `prettier` to `biome`. - Upgrade to Typescript 5, @actions/github 6 and other dependencies. - **Upgraded to use Node 20.** - Apply bobheadxi#152 to allow required status contexts and auto merge. Changes were made to make the values cleaner and fix some incorrect assumptions. - Apply bobheadxi/deploys#159 to add a warning when `delete-env` fails. - Remove makefile - Add a changelog file.
halostatue
added a commit
to KineticCafe/deployments
that referenced
this pull request
Mar 11, 2024
Adopted bobheadxi/deployments as KineticCafe/deployments, mostly to use Node 20 as required by GitHub. ```diff - uses: bobheadxi/deployments@v1 + uses: KineticCafe/deployments@v1 ``` We recommend using a more specific version tag: ```diff - uses: bobheadxi/deployments@v1 + uses: KineticCafe/[email protected] ``` - Switch from `npm` to `pnpm` - Switch from `prettier` to `biome`. - Upgrade to Typescript 5, @actions/github 6 and other dependencies. - **Upgraded to use Node 20.** - Apply bobheadxi#152 to allow required status contexts and auto merge. Changes were made to make the values cleaner and fix some incorrect assumptions. - Apply bobheadxi/deploys#159 to add a warning when `delete-env` fails. - Remove makefile - Add a changelog file.
halostatue
added a commit
to KineticCafe/deployments
that referenced
this pull request
Mar 11, 2024
Adopted bobheadxi/deployments as KineticCafe/deployments, mostly to use Node 20 as required by GitHub. ```diff - uses: bobheadxi/deployments@v1 + uses: KineticCafe/deployments@v1 ``` We recommend using a more specific version tag: ```diff - uses: bobheadxi/deployments@v1 + uses: KineticCafe/[email protected] ``` - Switch from `npm` to `pnpm` - Switch from `prettier` to `biome`. - Upgrade to Typescript 5, @actions/github 6 and other dependencies. - **Upgraded to use Node 20.** - Apply bobheadxi#152 to allow required status contexts and auto merge. Changes were made to make the values cleaner and fix some incorrect assumptions. - Apply bobheadxi/deploys#159 to add a warning when `delete-env` fails. - Remove makefile - Add a changelog file.
Thanks for the contribution - if you're still interested in landing this, could you resolve the conflicts and remove the extraneous docs formatting changes? Thank you! |
gjtorikian
force-pushed
the
support-more-deployments-logic
branch
from
March 26, 2024 17:44
6620363
to
d64f1c4
Compare
gjtorikian
force-pushed
the
support-more-deployments-logic
branch
from
March 26, 2024 17:45
d64f1c4
to
5f3864a
Compare
Sure, I've done that, and run prettier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the action to provide more configuration options when creating a deploy, by providing input support for
auto_merge
andrequired_contexts
. More details can be found in the GitHub API docs: https://docs.github.com/en/rest/deployments/deployments?apiVersion=2022-11-28#create-a-deploymentauto_merge
is fairly straightforward. It is currently defaulting tofalse
, and we can preserve that in this change for backwards compatibility.required_contexts
, on the other hand, has three states:["test", "lint"]
, which is a specific list of contexts to run[]
, which ignores all the contextsundefined
, which means, "run the default list of contexts"Currently,
required_contexts
is set to[]
. In order to preserve backwards compatibility, users will have to pass an explicit"null"
string for this input (supporting case 3). Omitting this input will skip all the required checks (case 2, the current case). Providing a multiline string covers case 1: