Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ feat a provider for twitch oauth2 #4

Merged
merged 18 commits into from
Oct 4, 2023

Conversation

iagocalazans
Copy link
Contributor

No description provided.

@iagocalazans
Copy link
Contributor Author

Still coding some automates for Twitch, do not merge it yet.

@iagocalazans
Copy link
Contributor Author

iagocalazans commented Sep 29, 2023

commit 49ea965
solves #1
@bogeychan

@bogeychan
Copy link
Owner

bogeychan commented Oct 2, 2023

Hi 👋, thanks for your contribution!

However, I am not able to merge it:

  • you're trying to add two features in one pull request
  • a large part of the changes you suggest is not compatible for everyone
  • a few things are redundant

Overall, we strive to comply with RFC6749 → there is no verify (like twitch does)

  • i know there is a tweak for reddit (soon to be removed from the "core" library)

src/providers/twitch.ts Outdated Show resolved Hide resolved
src/providers/twitch.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@iagocalazans iagocalazans requested a review from bogeychan October 3, 2023 21:12
@bogeychan
Copy link
Owner

this will be published within the next few minutes → 0.0.15

@bogeychan bogeychan merged commit 7f97fb1 into bogeychan:master Oct 4, 2023
@iagocalazans iagocalazans deleted the feat/twitch-provider branch October 4, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants