Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(states): add endpoints required for location state #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pitust
Copy link

@pitust pitust commented Dec 1, 2023

The tesla API updated, requiring the endpoints parameter in vehicle_data to return some types of information (like vehicle location). Add this parameter to the request so that the existing API continues to function.

@bogosj bogosj requested a review from andig December 1, 2023 21:45
@andig
Copy link
Collaborator

andig commented Dec 2, 2023

I don‘t know if thats required, but may be (Owners api). In Go, I‘d suggest to let the url Library do the escaping instead of writing escaped strings directly as it is error prone.

The tesla API updated, requiring the endpoints parameter in vehicle_data to
return some types of information (like vehicle location). Add this parameter to
the request so that the existing API continues to function.
@pitust
Copy link
Author

pitust commented Dec 2, 2023

I don‘t know if thats required, but may be (Owners api).

It is required to get the location information (latitude, longitude) via the API.

In Go, I‘d suggest to let the url Library do the escaping instead of writing escaped strings directly as it is error prone.

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants