Removed Istio specific images as they are no longer needed (#199)

scuttle is no longer needed with

proxy.istio.io/config: '{ "holdApplicationUntilProxyStarts": true }'

.github/workflows/rust.yml

@@ -363,26 +363,10 @@ jobs:
           push: true
           tags: bolcom/unftp:${{ env.BUILD_VERSION }}-alpine
 
-      - name: Build and push alpine-istio image
-        uses: docker/build-push-action@v2
-        with:
-          context: .
-          file: ./packaging/docker/alpine-istio.Dockerfile.ci
-          push: true
-          tags: bolcom/unftp:${{ env.BUILD_VERSION }}-alpine-istio
-
       - name: Build and push alpine-debug image
         uses: docker/build-push-action@v2
         with:
           context: .
           file: ./packaging/docker/alpine-debug.Dockerfile.ci
           push: true
           tags: bolcom/unftp:${{ env.BUILD_VERSION }}-alpine-debug
-
-      - name: Build and push Scratch image
-        uses: docker/build-push-action@v2
-        with:
-          context: .
-          file: ./packaging/docker/alpine-istio-debug.Dockerfile.ci
-          push: true
-          tags: bolcom/unftp:${{ env.BUILD_VERSION }}-alpine-istio-debug

CHANGELOG.md

@@ -7,6 +7,7 @@
 - [#196](https://github.com/bolcom/unFTP/pull/196) --auth-type is now mandatory to prevent security risks from omission or typos that could leave the FTP server open
 - Upgraded dependencies
 - Upgraded to Rust 1.83.0
+- Removed istio (scuttle) image build in favor of using `proxy.istio.io/config: '{ "holdApplicationUntilProxyStarts": true }'`
 
 ## 2023-12-24 unftp v0.14.7
 

README.md

@@ -40,8 +40,6 @@ We offer 3 different options for building an unFTP docker image:
 - `scratch`: builds the binary in [rust:slim](https://hub.docker.com/_/rust) and deploys in a `FROM scratch` image. The unFTP binary is statically linked using [musl libc](https://www.musl-libc.org/).
 - `alpine` (default): builds in [rust:slim](https://hub.docker.com/_/rust) and deploy in alpine. This image is built with musl instead of a full-blown libc. The unFTP binary is statically linked using [musl libc](https://www.musl-libc.org/).
 - `alpine-debug`: same images as `alpine` but using the debug build of unftp and adds tools like [lftp](https://lftp.yar.ru/) and [CurlFtpFS](http://curlftpfs.sourceforge.net/) while also running as root.
-- `alpine-istio`: same as `alpine` but with [scuttle](https://github.com/redboxllc/scuttle) installed. For use together with [Istio](https://istio.io/).
-- `alpine-istio-debug`: same as alpine-debug but with the additions of `alpine-istio`.  
 
 To build the alpine docker image:
 

RELEASE-CHECKLIST.md

@@ -1,6 +1,8 @@
 # Release Checklist
 
 * Update the Rust version in the Makefile and the Github actions file
+* Update the Rust version in packaging/docker/*.ci
+* Update the alpine version in the packaging/docker/alpine.Dockerfile.ci image
 * Update minor versions dependencies. Install [cargo-edit](https://crates.io/crates/cargo-edit) and run `cargo upgrade`.
   Cargo-edit also covers all the crates in the workspace
 * Update Cargo.toml with the new version number (also check for libunftp version references)

docs/server/docker.md

@@ -6,7 +6,6 @@ You can download pre-made docker images from [docker hub](https://hub.docker.com
 
 ```sh
 docker pull bolcom/unftp:v0.14.7-alpine
-docker pull bolcom/unftp:v0.14.7-alpine-istio
 docker pull bolcom/unftp:v0.14.7-scratch
 ```
 

packaging/docker/alpine-debug.Dockerfile.ci

@@ -1,9 +1,9 @@
-FROM rust:1.70.0-slim AS builder
+FROM rust:1.83.0-slim AS builder
 
-FROM alpine:3.17
+FROM alpine:3.21
 
 # for devel only
-RUN apk add --repository http://dl-cdn.alpinelinux.org/alpine/v3.17/main fuse lftp curl
+RUN apk add --repository http://dl-cdn.alpinelinux.org/alpine/v3.21/main fuse lftp curl
 RUN apk add --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing curlftpfs
 
 # we could also RUN 'apk add ca-certificates', but we prefer to be consistent with the -minimal image

packaging/docker/alpine.Dockerfile.ci

@@ -1,4 +1,4 @@
-FROM rust:1.70.0-slim AS builder
+FROM rust:1.83.0-slim AS builder
 
 FROM alpine:latest
 

packaging/docker/scratch.Dockerfile.ci

@@ -1,4 +1,4 @@
-FROM rust:1.70.0-slim AS builder
+FROM rust:1.83.0-slim AS builder
 
 FROM scratch