-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Fedora Polkit #687
base: master
Are you sure you want to change the base?
Fix Fedora Polkit #687
Conversation
@principis What do you think of that? |
Works flawlessly, can confirm from Fedora 36. Thanks so much! |
So, do I only need to modify |
Yes, just change the line 44 of status = subprocess.call(["/usr/bin/python3 " + os.path.dirname(os.path.abspath(__file__)) + "/compare.py " + pamh.get_user() + " &> /dev/null"], shell=True) |
this is fantastic, thanks, +1 for merging or copr repo hotfix |
I can confirm that this also worked for my installation. |
I'll add this in the copr repo. |
Is polkit exclusive to Fedora, or is it a Gnome thing? |
The next release of Howdy will completely remove pam.py to move over to a compiled pam_howdy.so and drop the dependency on pam-python. This file is now gone on the beta branch. Is it worth merging this into master still? |
@wheelerlaw A Gnome thing |
This is a fix for the issue #630
If think that on Fedora, polkit detect that the subprocess
compare.py
is created and to avoid security issue it is killed.However, if we run this subprocess through a shell instance, this is no more a problem.
So this fix is not really clean, but it works.
In order to provide a proper solution, I think we need to investigate polkit to create a policy or something like that. But personally, I don't know anything about it, and this seems complex. It is also possible that there is no such thing and that it is simply a bug.
I made the modification from the tag of the current version of Howdy: v2.6.1.
In order to provide this fix for Fedora users we have several choices:
fedora-polkit
branch of my fork, which is temporarily used as source. The version on Fedora would become 2.6.1-7