Connect to signals of the shown window #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of OnboardingWindow and MainWindow, the class itself is not shown as a window, but its 'window' field is shown, so when the window is closed, the application does not terminate - the wrong signals is connected to the handler.
Gliese852
force-pushed
the
fix-wrong-signals
branch
from
a8c9e7c to
bcde184
Compare
|
I corrected it a little, because it is not always called with all the args. (An error occurred when clicking the "Cancel" button in the wizard.) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of
OnboardingWindowandMainWindow, the class itself is not shown as a window, but itswindowfield is shown, so when the window is closed, the application does not terminate - the wrong signals is connected to the handler.