Added OTP automation feature via Google Messages web-application #389
Conversation
|
Awesome! As the PR seems to be not tested, I will leave it here for couple of days. At others who successfully book slots using this PR, please mention here so that we can get confidence to merge this. |
|
Thanks for the contribution but it seems like this is going to create more issues saying "No chromium driver found" |
I guess that was because of selenium missing from your packages? I have updated the requirements.txt as well, for any new installs. |
|
| otp_automation_pref = input("\nDo you want to automate the OTP using 1.Google Messages via Chrome 2. Autoread app ? (Default 2):") | ||
| if(otp_automation_pref == "1"): | ||
| print("Please scan the QR code within 20 seconds.") | ||
| messages_driver = webdriver.Chrome(executable_path=r'./src/chromedriver') |
There was a problem hiding this comment.
Checkout the path here. As most people will execute it directly from the root folder, I have added it as src/chromedriver
There was a problem hiding this comment.
Can we make it work in both the cases? There will be people who may directly run the python file from the machine's home folder once the initial setup is done.
Restricting somebody to always navigate to a particular path and then execute is not a good practice and may confuse many.
There was a problem hiding this comment.
Sure, it is possible. A simple try-except block should resolve it.
This PR includes another way to fetch OTP via the user's browser by automating Google Message web client.
Consideration: Might require slight testing.