Usage debug #285
Merged
Usage debug #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous design allowed usage report to be sent for Legacy plugins only when debugMode was set to true.
|
This PR should be approved and merged after #283 due to the scijava version bump commit that is hanging around here. |
| reader.lines().forEach(IJ::log); | ||
| } | ||
| } catch (final IOException e) { | ||
| IJ.error(e.getMessage()); | ||
| } |
There was a problem hiding this comment.
I am probably being silly but I don't understand how the changes make a difference.
The only thing I see changing when IJ.debugMode is false is that the reader variable gets constructed, and then goes out of scope at the end of the send() function?
There was a problem hiding this comment.
Right - no idea either. I knocked out some lines to see what is essential and it's this:
final BufferedReader reader = new BufferedReader(new InputStreamReader(uc.getInputStream()))Which I interpret to mean that the request isn't actually sent until the BufferedReader tries to read from the URLConnection. Or something like that.
alessandrofelder
approved these changes
Feb 10, 2021
mdoube
added a commit
that referenced
this pull request
Apr 5, 2024
* Update scijava to 30.0.0 * Allow usage report to be sent for Legacy plugins Previous design allowed usage report to be sent for Legacy plugins only when debugMode was set to true. * Comment to explain structure of send() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage data were not being collected for Legacy plugins when debug mode was off.