Filter out redundant surface mesh vertices #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triangles in the surface mesh share vertices but the vertices are repeated for every triangle in the mesh. This change reduces the number of points for the surface by 4-6× and should in principle reduce the time for brute-force all-to-all calculations used by Feret max by 16-36×.
alessandrofelder
approved these changes
Oct 2, 2023
Surface Area calculation requires the triangles to be complete, so it doesn't call the filtering method. Only ellipsoid fitting and feret max, which don't care about triangles, use the filtering method. |
mdoube
added a commit
that referenced
this pull request
Apr 5, 2024
Triangles in the surface mesh share vertices but the vertices are repeated for every triangle in the mesh. This change reduces the number of points for the surface by 4-6× and should in principle reduce the time for brute-force all-to-all calculations used by Feret max by 16-36×.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triangles in the surface mesh share vertices but the vertices are repeated for every triangle in the mesh. This change reduces the number of points for the surface by 4-6× and should in principle reduce the time for brute-force all-to-all calculations used by Feret max by 16-36×. In testing on small meshes there is a several-fold speed up but not as much as predicted.