-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add area download FAB #145
base: main
Are you sure you want to change the base?
Conversation
Great! I found 2 bugs however: 1/ I go in "Franchard Sablons" and tap on the FAB and download the area IMG_9998.MOV2/ I go in "Franchard Sablons" and tap on the FAB and download the area Bug 1 is really annoying, let's fix it before we ship? |
4185107
to
cebb98d
Compare
cebb98d
to
d5ee023
Compare
@nmondollot Here is a demo of the downloads on the map, handling the clusters cluster_download_2.mp4 |
Great! My main feedback: 1/ the downloads are significantly slower than on iOS, why? 2/ when I try to download a whole cluster, I find it hard to understand the download progress because the spinners are all moving at different speeds 3/ on iOS I decided to always show the fab button on the map, to make the UI more consistent 4/ at first launch (no mapbox cache), when I tap on a cluster on the map (example: Buthiers) the fab button doesn't show up, probably because the cluster isn't selected properly Other feedback:
|
In order to ease the download of the photos for an area, an additional FAB has been added. This FAB will appear when an area is focused on the map. A click on it will display a bottom sheet to manage the download of the current area, along with the nearby ones.
area_download_bottom_sheet.mp4