Fixed Mootools Conflics #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I noticed a bug which doesn't allow Slippry to coexist with the Mootools library. Especially with either
mootools-core.jsormootools-more.js. However I needed both Slippry and Mootools to be on the same page in one of my projects so I decided to create a pull request which reflects my changes which were necessary to get it to work correctly. The problem originates in theloadevent which is triggered on preload of the slider images. This somehow causes serious issues with Mootools. One important reference I have to make is an other pull request of another repository which pointed me in the right direction #53 - Collage Plus.Basically I simply replaced the default
loadevent with a custom one calledloads(s for slippery). With the proposed changes it now works without any issues.Edit: Updated image load
triggerto react on cached and non cached page load.