Wider layout support #736
Wider layout support #736
Conversation
This change allows the doc directory, single doc read, edit and history screens to be wider in twentyeighteen, nineteen, twenty and twentyone. See boonebgorges#731.
Rather than echoing the code immediately, pass it back to the `bp_replace_the_content` filter. This prevents BP Nouveau from generating a second `div#buddypress`. This fixes and breaks block-based theme layouts. No longer is the directory echoed out before the page content, but it is also truncated into an excerpt (and will require further repairs).
|
Technique looks good! Thanks for looking at it.
What are our options here? |
|
I've only just begun looking at the archive problem. Something cool about the new full-site-editing, block-based themes is that you finally can have some control over your site's archive layout without making a new archive template. (I only played with this today, but remember reading about archive layouts being more accessible.) Maybe archives will become slightly less misunderstood. The problem is that when we overload the content with theme compatibility enabled (these examples all use Twenty Twenty-Two as the theme), the default archive layout shows the BP Docs content as an excerpt: If I disable theme compatibility on directories with these themes, we get our content, but not built out like other screens. (It flows edge to edge in the browser): So I'm not sure what the answer is, yet. I'm not familiar with this style of theme, so I'm learning some interesting things. I was hoping that this question had been solved by Mathieu for BP, and it may be, but I'm not sure that BP has to overload content on archives, and the overload works as expected on single views: |
Addresses issues in #731. Also causes new problems for block-based themes. :)