Feat/test #10
Open
Feat/test #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinmyeongAN
approved these changes
Jan 3, 2023
|
|
||
| test_object = ProfileRetrieval() | ||
| profiler = Profile() | ||
| profiler.runcall(test_object.test) |
There was a problem hiding this comment.
이거 너무 좋네요!!
파이썬 같은 동적인 언어에는 반드시 필요한 존재 같아요
tests/test_arguments.py
Outdated
|
|
||
|
|
||
| class TestArguments(unittest.TestCase): | ||
| @classmethod |
There was a problem hiding this comment.
아래 preprocess나 retrieval 클래스 안에 있는 setUP함수와 달리 TestArguments 의 setUpClass 함수는 왜 클래스 메서드를 사용하는지 궁금해요
There was a problem hiding this comment.
사실 큰 이유 없는 레거시 코드의 흔적 입니다....!! 의견 감사합니다!! 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
테스트 코드와 프로파일링 코드를 추가하였습니다.
실행방법
코드 테스팅 및 커버리지 측정
make testmake coverage프로파일링
make profile자세한 프로파일링 코드는 tests/profile_retrieval.py에서 확인 가능합니다.
Related Issue
None.