[feat] 로그인페이지 네비게이션 #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flashdragon
added
✨ Enhancement
ruh0n
reviewed
Nov 11, 2024
core/data/build.gradle.kts
Outdated
| @@ -2,6 +2,7 @@ plugins { | |||
| alias(libs.plugins.dreamdiary.android.library) | |||
| alias(libs.plugins.ksp) | |||
| alias(libs.plugins.room) | |||
| id("com.google.gms.google-services") | |||
There was a problem hiding this comment.
version catalog로 통일하는 것이 더 좋을 것 같습니다.
Comment on lines
38
to
+42
| // firebase | ||
| implementation(libs.firebase.firestore) | ||
| implementation(libs.googleid) | ||
| implementation(libs.play.services.auth) | ||
| implementation(libs.firebase.auth.ktx) |
There was a problem hiding this comment.
주석과 함께 카테고리를 통일해주시는 것이 좋을 것 같습니다
| private val googleLogInDataSource: GoogleLogInDataSource, | ||
| private val authRepository: AuthRepository, | ||
| ) { | ||
| suspend operator fun invoke(data: Intent?): Result<Unit> { |
There was a problem hiding this comment.
result 클래스를 사용할 때
특별한 목적이 없다면 runcatching 블럭을 사용하는 것이 좋지 않을까요?
Comment on lines
+21
to
+23
| } catch (e: Exception) { | ||
| Result.failure(e) | ||
| } |
There was a problem hiding this comment.
모듈이 분리되어 있기 때문에
throwable을 그냥 전달하는 것은 위험할 수 있을 것 같습니다.
Comment on lines
4
to
6
| object NotLogin : LoginState() | ||
|
|
||
| object Success : LoginState() |
gradle/libs.versions.toml
Outdated
Comment on lines
67
to
69
| firebase-firestore = { group = "com.google.firebase", name = "firebase-firestore", version.ref = "firebaseFirestore" } | ||
| googleid = { group = "com.google.android.libraries.identity.googleid", name = "googleid", version.ref = "googleid" } | ||
| play-services-auth = { module = "com.google.android.gms:play-services-auth", version.ref = "playServicesAuth" } |
There was a problem hiding this comment.
그래들 플러그인과 다른 부분에 작성해주시는 것이 좋을 것 같습니다
| } | ||
|
|
||
| fun loginWithGoogle(data: Intent?) { | ||
| viewModelScope.launch { |
There was a problem hiding this comment.
잘 몰라서 여쭙습니다.
dispatcher.io io 스레드에서 작동하는 것과 차이가 있을까요?
easyhak
reviewed
Nov 11, 2024
| return try { | ||
| val account = task.await() | ||
| account.idToken | ||
| } catch (e: ApiException) { |
There was a problem hiding this comment.
ApiExeption말고 처리가 안되는 exception이 있을 수도 있으니 catch (e : Excetpion)을 쓰는 것은 어떨까요?
| @@ -0,0 +1,4 @@ | |||
| <resources> | |||
| <string name="app_name">dreamdiary</string> | |||
| <string name="google_client_id">105289032792-nfs3tv76a867aajjt5q4n95rogtp1dje.apps.googleusercontent.com</string> | |||
| onGitHubLogInClick: () -> Unit = {}, | ||
| onGoogleLogInClick: () -> Unit = {}, | ||
| onNotLogInClick: () -> Unit = {}, | ||
| modifier: Modifier = Modifier, | ||
| ) { |
There was a problem hiding this comment.
여기에 기본값이 있어야하나요? 기본값이 있어야한다면 modifer는 선택적 매개변수의 첫번째입니다.
Co-authored-by: easyhak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6
close #7