[FIX/#204] firebase / storage 업로드 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 특정 api(35) 기기에서 업데이트 불가 현상 수정 - withTimeout 제거
- play_store 앱 배포시 검증된 유저만 firestore, storage에 접근 가능하게 설정
TaewoongR
requested review from
Ameri-Kano,
haeti-dev and
shinythinking
and removed request for
a team
shinythinking
approved these changes
Dec 4, 2024
Ameri-Kano
approved these changes
Dec 4, 2024
Comment on lines
187
to
189
| val createdBy = database.collection("user").document(episodeModel.createdBy) | ||
| val group = database.collection("group").document(episodeModel.group) | ||
| database.document("episode/${episodeModel.id}") |
There was a problem hiding this comment.
정의된 상수 사용해주셔도 좋을 것 같습니다!
haeti-dev
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 Work Description
📸 Screenshot
📢 To Reviewers
⏲️Time