[FIX/#197] 에피소드 생성 기능 버그 수정 및 성능 개선 #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ameri-Kano
requested review from
haeti-dev,
TaewoongR and
shinythinking
and removed request for
a team
에피소드 생성 중 버튼 비활성화 및 스로틀링 처리 추가
Ameri-Kano
force-pushed
the
fix/new-episode
branch
from
2018d93 to
6d86b3c
Compare
shinythinking
approved these changes
Dec 4, 2024
Comment on lines
+185
to
+188
| .clickable( | ||
| enabled = false, | ||
| onClick = {}, | ||
| ) |
There was a problem hiding this comment.
false로 두지 않으면 클릭이 되나요??
There was a problem hiding this comment.
클릭이 되지만 onClick이 비어서 실제로 아무 동작을 하지는 않을 것 같습니다!
Comment on lines
+218
to
+221
| MapisodeTagInputField( | ||
| tagList = uiState.episodeInfo.tags, | ||
| onTagChange = { newTags -> tagValue = newTags }, | ||
| ) |
There was a problem hiding this comment.
태그를 적용하셨군요! 수고 많으셨습니다
There was a problem hiding this comment.
태웅님이 구현하신거 그대로 쓴거긴 합니다 ㅎㅎ
| private const val DATE_STRING_FORMAT = "yyyy. MM. dd" | ||
| private fun dateString(date: Date): String = | ||
| DateFormat.format(DATE_STRING_FORMAT, date).toString() | ||
|
|
||
| @OptIn(ExperimentalLayoutApi::class) | ||
| @Composable |
There was a problem hiding this comment.
공백이나 중복 태그에 대한 설정도 하면 좋을 것 같아요
haeti-dev
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 Work Description
📸 ScreenShots
버튼 높이 고정하여 일치
📢 To Reviewers
⏲️Time