[FIX/#220] Group / state 변경 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- core:model의 모델을 state로 사용 -> 화면 전용 immutable 모델 선언 및 state 사용
- core:model의 모델을 state로 사용 -> 화면 전용 immutable 모델 선언 및 state 사용 - uiState 선언시 등호 대신 by 사용하여 State 내부 타입 바로 접근
TaewoongR
requested review from
Ameri-Kano,
haeti-dev and
shinythinking
and removed request for
a team
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Ameri-Kano
approved these changes
Dec 5, 2024
haeti-dev
approved these changes
Dec 5, 2024
Comment on lines
+9
to
+18
| @Immutable | ||
| data class GroupUiModel( | ||
| val id: String, | ||
| val adminUser: String, | ||
| val createdAt: Date, | ||
| val description: String, | ||
| val imageUrl: String, | ||
| val name: String, | ||
| val members: ImmutableList<String>, | ||
| ) { |
There was a problem hiding this comment.
GroupUiModel에 꼭 Immutable을 붙여야 하는 이유가 Date 때문인가요?
There was a problem hiding this comment.
이렇게 Immutable을 선언해도 해도 Date 객체가 java.util 에서 제공하는 거라 객체는 unstable이겠네요.
java.util 의 Date 대신 kotlinx 에서 제공하는 LocalDate 타입 쓰면 immutable 타입으로 사용 가능하다 하는데 이거로 대체하기에는 시간이 없네요 ㅠㅠ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 Work Description
📢 To Reviewers
⏲️Time