Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ test: 전체 통계 API 테스트 코드 작성 #264

Merged
merged 6 commits into from
Dec 3, 2024
+36 −141
Merged

✅ test: 전체 통계 API 테스트 코드 작성 #264

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
35e22b1
⚡️ perf: 단 1회 DB에 저장하도록 변경
Jo-Minseok Dec 2, 2024
bc961f5
✅ test: dto 테스트 분리, 테스트 데이터 개수, 범위 축소
Jo-Minseok Dec 2, 2024
36c141b
🧼 clean: 테스트 컨벤션 맞추기
Jo-Minseok Dec 2, 2024
260af46
🧼 clean: request -\> supertest
Jo-Minseok Dec 2, 2024
433b032
🧼 clean: supertest -\> request
Jo-Minseok Dec 2, 2024
4117ea0
🧼 clean: promise.all -\> 단순 await으로 변경
Jo-Minseok Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
162 changes: 27 additions & 135 deletions server/test/statistic/all.e2e-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,154 +1,46 @@
import * as request from 'supertest';
import { INestApplication } from '@nestjs/common';
import { RedisService } from '../../src/common/redis/redis.service';
import { RssAcceptRepository } from '../../src/rss/rss.repository';
import { FeedRepository } from '../../src/feed/feed.repository';
import { RssAcceptFixture } from '../fixture/rssAccept.fixture';
import { FeedFixture } from '../fixture/feed.fixture';
import { Feed } from '../../src/feed/feed.entity';

describe('All view count statistic E2E Test : GET /api/statistic/all', () => {
describe('GET /api/statistic/all E2E Test', () => {
let app: INestApplication;

beforeAll(async () => {
app = global.testApp;
const rssAcceptRepository = app.get(RssAcceptRepository);
const feedRepository = app.get(FeedRepository);
const redisService = app.get(RedisService);
const [blog] = await Promise.all([
rssAcceptRepository.save({
id: 1,
name: 'test',
userName: 'test',
email: '[email protected]',
rssUrl: 'https://test.com/rss',
}),
redisService.redisClient.set('auth:test1234', 'test'),
]);
await feedRepository.save([
{
id: 1,
createdAt: '2024-11-26 09:00:00',
title: 'test1',
path: 'test1',
viewCount: 5,
thumbnail: 'https://test.com/test.png',
blog: blog,
},
{
id: 2,
createdAt: '2024-11-26 09:00:00',
title: 'test2',
path: 'test2',
viewCount: 4,
thumbnail: 'https://test.com/test.png',
blog: blog,
},
{
id: 3,
createdAt: '2024-11-26 09:00:00',
title: 'test3',
path: 'test3',
viewCount: 3,
thumbnail: 'https://test.com/test.png',
blog: blog,
},
{
id: 4,
createdAt: '2024-11-26 09:00:00',
title: 'test4',
path: 'test4',
viewCount: 2,
thumbnail: 'https://test.com/test.png',
blog: blog,
},
{
id: 5,
createdAt: '2024-11-26 09:00:00',
title: 'test5',
path: 'test5',
viewCount: 1,
thumbnail: 'https://test.com/test.png',
blog: blog,
},
rssAcceptRepository.save(RssAcceptFixture.createRssAcceptFixture()),
]);
const feeds: Feed[] = [];
asn6878 marked this conversation as resolved.
Show resolved Hide resolved
for (let i = 1; i <= 2; i++) {
feeds.push(FeedFixture.createFeedFixture(blog, { viewCount: i - 1 }, i));
}
await feedRepository.save(feeds);
});

describe('limit 값을 올바르게 입력하지 않았을 경우', () => {
it('실수를 입력한다.', async () => {
const response = await request(app.getHttpServer())
.get('/api/statistic/all?limit=1.1')
.set('Cookie', 'sessionId=test1234');
expect(response.status).toBe(400);
expect(response.body.message).toBe('정수로 입력해주세요.');
});
it('문자열을 입력한다.', async () => {
const response = await request(app.getHttpServer())
.get('/api/statistic/all?limit=test')
.set('Cookie', 'sessionId=test1234');
expect(response.status).toBe(400);
expect(response.body.message).toBe('정수로 입력해주세요.');
});
it('값을 입력 하지 않으면 10개의 데이터만 응답한다.', async () => {
// when
const response = await request(app.getHttpServer()).get(
'/api/statistic/all',
);

it('음수를 입력한다.', async () => {
const response = await request(app.getHttpServer())
.get('/api/statistic/all?limit=-100')
.set('Cookie', 'sessionId=test1234');
expect(response.status).toBe(400);
expect(response.body).toStrictEqual({
message: 'limit 값은 1 이상이어야 합니다.',
});
});
// then
expect(response.status).toBe(200);
expect(response.body.data.map((item) => item.id)).toStrictEqual([2, 1]);
});
it('양수를 입력하면 제한된 개수의 통계 결과를 응답한다.', async () => {
// when
const response = await request(app.getHttpServer()).get(
'/api/statistic/all?limit=1',
);

describe('limit 값을 올바르게 입력했을 경우', () => {
it('값을 입력 하지 않는다.', async () => {
const response = await request(app.getHttpServer())
.get('/api/statistic/all')
.set('Cookie', 'sessionId=test1234');
expect(response.status).toBe(200);
expect(response.body).toStrictEqual({
message: '전체 조회수 통계 조회 완료',
data: [
{
id: 1,
title: 'test1',
viewCount: 5,
},
{
id: 2,
title: 'test2',
viewCount: 4,
},
{
id: 3,
title: 'test3',
viewCount: 3,
},
{
id: 4,
title: 'test4',
viewCount: 2,
},
{
id: 5,
title: 'test5',
viewCount: 1,
},
],
});
});
it('양수를 입력한다.', async () => {
const response = await request(app.getHttpServer())
.get('/api/statistic/all?limit=1')
.set('Cookie', 'sessionId=test1234');
expect(response.status).toBe(200);
expect(response.body).toStrictEqual({
message: '전체 조회수 통계 조회 완료',
data: [
{
id: 1,
title: 'test1',
viewCount: 5,
},
],
});
});
// then
expect(response.status).toBe(200);
expect(response.body.data.map((item) => item.id)).toStrictEqual([2]);
});
});
11 changes: 7 additions & 4 deletions server/test/statistic/today.e2e-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ import { RssAcceptFixture } from '../fixture/rssAccept.fixture';
import { FeedRepository } from '../../src/feed/feed.repository';
import { RssAcceptRepository } from '../../src/rss/rss.repository';
import { FeedFixture } from '../fixture/feed.fixture';
import { Feed } from '../../src/feed/feed.entity';

describe('Today view count statistic E2E Test : GET /api/statistic/today', () => {
describe('GET /api/statistic/today E2E Test', () => {
let app: INestApplication;

beforeAll(async () => {
Expand All @@ -19,11 +20,13 @@ describe('Today view count statistic E2E Test : GET /api/statistic/today', () =>
rssAcceptRepository.save(RssAcceptFixture.createRssAcceptFixture()),
redisService.redisClient.zadd(redisKeys.FEED_TREND_KEY, 5, '1', 4, '2'),
]);
const feeds: Feed[] = [];
for (let i = 1; i <= 2; i++) {
await feedRepository.save(FeedFixture.createFeedFixture(blog, {}, i));
feeds.push(FeedFixture.createFeedFixture(blog, {}, i));
}
await feedRepository.save(feeds);
});
it('값을 입력 하지 않아 10개의 데이터만 요청한다.', async () => {
it('값을 입력 하지 않으면 10개의 데이터만 응답한다.', async () => {
// when
const response = await request(app.getHttpServer()).get(
'/api/statistic/today',
Expand All @@ -33,7 +36,7 @@ describe('Today view count statistic E2E Test : GET /api/statistic/today', () =>
expect(response.status).toBe(200);
expect(response.body.data.map((item) => item.id)).toStrictEqual([1, 2]);
});
it('양수를 입력하여 제한된 통계를 요청한다.', async () => {
it('양수를 입력하면 제한된 개수의 통계 결과를 응답한다.', async () => {
// when
const response = await request(app.getHttpServer()).get(
'/api/statistic/today?limit=1',
Expand Down
Loading