♻️ refactor: admin, statistic 리팩토링 #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for denamu canceled.
|
CodeVac513
reviewed
Dec 3, 2024
Jo-Minseok
requested changes
Dec 3, 2024
복구 처리 완료했습니다. 확인해주세요~ |
… into refactor/admin-statistic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
📋 작업 내용
admin, statistic DAO 계층 분리.
전에 이야기 나왔던대로,
findOne같은 메소드들도 repository에서 커스텀화 해 사용할 수 있도록 수정하였습니다.admin, statistic Swagger 어노테이션 정의 분리
마찬가지로, 컨벤션에 맞추어 어노테이션을 API 별로 분리하였습니다.
admin, statistic Controller, Service Layer 메서드명 컨벤션
각 레어의 메서드명들을 컨벤션에 맞게 수정하였습니다.
📷 스크린 샷(선택 사항)
모든 테스트 정상 동작 됨을 확인 하였습니다.
