Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ refactor: rss 코드 정리 #279

Merged
merged 3 commits into from
Dec 4, 2024
Merged

♻️ refactor: rss 코드 정리 #279

merged 3 commits into from
Dec 4, 2024

Conversation

Jo-Minseok
Copy link
Collaborator

@Jo-Minseok Jo-Minseok commented Dec 3, 2024 •
edited
Loading

🔨 테스크

Issue

rss-notifier 정리

  • 무성님께서 코드 let에 대해 정리를 하고 계셔서 디렉토리 구조만 바꿨습니다. type, constant, logger, db-access 부분은 common으로 빼고, main과 rss-notifier 만 따로 둬서 유지보수에 유리하게 바꿨습니다.

📋 작업 내용

  • Rss Service IF 문 하나로 줄이기
  • rss-notifier 디렉토리 구조 변경

📷 스크린 샷(선택 사항)

image

@Jo-Minseok Jo-Minseok added the 🔨 Refactor 리팩토링 (구조 변경) label Dec 3, 2024
@Jo-Minseok Jo-Minseok requested a review from asn6878 December 3, 2024 16:30
@Jo-Minseok Jo-Minseok self-assigned this Dec 3, 2024
@Jo-Minseok Jo-Minseok requested a review from CodeVac513 December 3, 2024 16:30
@netlify Netlify
Copy link

netlify bot commented Dec 3, 2024 •
edited
Loading

✅ Deploy Preview for denamu canceled.

Name Link
🔨 Latest commit 618d0e4
🔍 Latest deploy log https://app.netlify.com/sites/denamu/deploys/674fb708d5bd8c00080bf76a

CodeVac513
CodeVac513 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@CodeVac513 CodeVac513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jo-Minseok Jo-Minseok merged commit 45caa47 into main Dec 4, 2024
1 check passed
@Jo-Minseok Jo-Minseok deleted the refactor/rss-api-performance branch December 4, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeVac513 CodeVac513 CodeVac513 approved these changes

@asn6878 asn6878 Awaiting requested review from asn6878

Assignees

@Jo-Minseok Jo-Minseok

Labels
🔨 Refactor 리팩토링 (구조 변경)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 코드 미흡한 부분 처리하기
2 participants
@Jo-Minseok @CodeVac513