Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ test: search dto 테스트 코드 작성 #285

Merged
merged 2 commits into from
Dec 4, 2024
Merged

✅ test: search dto 테스트 코드 작성 #285

merged 2 commits into from
Dec 4, 2024

Conversation

Jo-Minseok
Copy link
Collaborator

@Jo-Minseok Jo-Minseok commented Dec 4, 2024 •
edited
Loading

🔨 테스크

Issue

Search 테스트 불가능 상황

  • 현재 테스트 DB가 Sqlite InMemory DB이기에 MySQL에 있는 Full Text Index Search를 사용할 수 없다.
  • 최소한 DTO 테스트라도 해야할 것 같아서 작성했다.

📋 작업 내용

  • 최소 수 검증 기능 추가
  • Search Request DTO 테스트

📷 스크린 샷(선택 사항)

image

@Jo-Minseok Jo-Minseok added the ✅ Test 테스트 관련 (storybook, vitest, jest 등) label Dec 4, 2024
@Jo-Minseok Jo-Minseok self-assigned this Dec 4, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 4, 2024

✅ Deploy Preview for denamu canceled.

Name Link
🔨 Latest commit 1de4de2
🔍 Latest deploy log https://app.netlify.com/sites/denamu/deploys/674fc1510fbb7100081ece5e

asn6878
asn6878 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@asn6878 asn6878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 Min 값을 놓쳤군요 😢 처리해주셔서 감사합니다!
확인 완료했어요~ 👍

CodeVac513
CodeVac513 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@CodeVac513 CodeVac513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jo-Minseok Jo-Minseok merged commit f96fa82 into main Dec 4, 2024
1 check passed
@Jo-Minseok Jo-Minseok deleted the test/search-feed branch December 4, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asn6878 asn6878 asn6878 approved these changes

@CodeVac513 CodeVac513 CodeVac513 approved these changes

Assignees

@Jo-Minseok Jo-Minseok

Labels
✅ Test 테스트 관련 (storybook, vitest, jest 등)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 키워드별 검색 API 구현
3 participants
@Jo-Minseok @CodeVac513 @asn6878