Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] 7차 배포 (12.06) #388

Merged
merged 3 commits into from
Dec 6, 2024
Merged

[Release] 7차 배포 (12.06) #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
950a94b
refactor: simplify media stream constraints
seoko97 Dec 5, 2024
45c63cb
refactor: 사용하지 않는 코덱 정보 제거
seoko97 Dec 5, 2024
b9980ff
Merge pull request #387 from boostcampwm-2024/fix/#385/stream
seoko97 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions apps/media/src/mediasoup/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,6 @@ export class MediasoupConfig {
useinbandfec: 1,
},
},
{
kind: 'video',
mimeType: 'video/H264',
clockRate: 90000,
parameters: {
'packetization-mode': 1,
'profile-level-id': '42e01f',
},
},
{
kind: 'video',
mimeType: 'video/VP8',
Expand Down
28 changes: 3 additions & 25 deletions apps/web/src/utils/stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,43 +6,21 @@ const DEFAULT_AUDIO_CONSTRAINTS: MediaTrackConstraints = {
autoGainControl: true,
};

const DEFAULT_VIDEO_CONSTRAINTS: MediaTrackConstraints = {
width: { ideal: 1280, min: 640, max: 1920 },
height: { ideal: 720, min: 360, max: 1080 },
frameRate: { max: 30, ideal: 15, min: 15 },
aspectRatio: { ideal: 16 / 9 },
};

const DEFAULT_SCREEN_CONSTRAINTS: MediaTrackConstraints = {
width: { max: 1920, ideal: 1280 },
height: { max: 1080, ideal: 720 },
frameRate: { max: 30, ideal: 15 },
};

const getCameraStream = async (options: MediaTrackConstraints = {}) => {
return navigator.mediaDevices.getUserMedia({
video: {
...DEFAULT_VIDEO_CONSTRAINTS,
...options,
},
video: { ...options },
});
};

const getMicStream = async (options: MediaTrackConstraints = {}) => {
return navigator.mediaDevices.getUserMedia({
audio: {
...DEFAULT_AUDIO_CONSTRAINTS,
...options,
},
audio: { ...DEFAULT_AUDIO_CONSTRAINTS, ...options },
});
};

const getScreenStream = async (options: MediaTrackConstraints = {}) => {
return navigator.mediaDevices.getDisplayMedia({
video: {
...DEFAULT_SCREEN_CONSTRAINTS,
...options,
},
video: { ...options },
});
};

Expand Down
Loading