Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#267 이미지 최적화 #301

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Feature/#267 이미지 최적화 #301

merged 2 commits into from
Dec 5, 2024

Conversation

pipisebastian
Copy link
Member

📝 변경 사항

  • 기존에는 css @support로 지원하게 했는데, avif를 지원함에도 webp를 받아왔습니다
  • 이에 picture 태그를 이용해 avif를 우선으로 받아오도록 수정했습니다.

🔍 변경 사항 설명

  • 변경 사항이 코드에 어떻게 반영되었는지, 특히 리뷰어가 주의해야 할 부분이 있다면 상세히 설명합니다.

🙏 질문 사항

  • 리뷰어에게 부탁하고싶은 체크리스트를 추가합니다.

📷 스크린샷 (선택)

image

✅ 작성자 체크리스트

  • Self-review: 코드가 스스로 검토됨
  • Unit tests 추가 또는 수정
  • 로컬에서 모든 기능이 정상 작동함
  • 린터 및 포맷터로 코드 정리됨
  • 의존성 업데이트 확인
  • 문서 업데이트 또는 주석 추가 (필요 시)

@pipisebastian pipisebastian added the FE 프론트엔드 작업 label Dec 5, 2024
@pipisebastian pipisebastian self-assigned this Dec 5, 2024
Ludovico7
Ludovico7 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@Ludovico7 Ludovico7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

hyonun321
hyonun321 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@hyonun321 hyonun321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 !!

minjungw00
minjungw00 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@minjungw00 minjungw00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니다!

@github-actions github-actions bot merged commit 282ebc6 into dev Dec 5, 2024
6 checks passed
@pipisebastian pipisebastian deleted the Feature/#267_이미지_최적화 branch December 5, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyonun321 hyonun321 hyonun321 approved these changes

@Ludovico7 Ludovico7 Ludovico7 approved these changes

@minjungw00 minjungw00 minjungw00 approved these changes

Assignees

@pipisebastian pipisebastian

Labels
FE 프론트엔드 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pipisebastian @minjungw00 @Ludovico7 @hyonun321