289 fix ranking api not working (#291)

* querybuilder를 이용한, 제대로 된 ranking api 구현, 버그 수정 완료. 아직은 미완성

* filter out duplicate AC submissions

server/src/entities/submission.entity.ts

@@ -1,11 +1,11 @@
-import { Status } from '../const/boj-results';
 import {
   BaseEntity,
   Column,
   Entity,
   ManyToOne,
   PrimaryGeneratedColumn,
 } from 'typeorm';
+import { Status } from '../const/boj-results';
 import Problem from './problem.entity';
 import Room from './room.entity';
 import User from './user.entity';
@@ -37,4 +37,7 @@ export default class Submission extends BaseEntity {
 
   @ManyToOne(() => Problem, (problem) => problem.submissions, { cascade: true })
   problem?: Problem;
+
+  @Column()
+  alreadyAccepted!: boolean;
 }

server/src/room/room-code/room-code.pipe.spec.ts

@@ -0,0 +1,7 @@
+import { RoomCodePipe } from './room-code.pipe';
+
+describe('RoomCodePipe', () => {
+  it('should be defined', () => {
+    expect(new RoomCodePipe()).toBeDefined();
+  });
+});

server/src/room/room-code/room-code.pipe.ts

@@ -0,0 +1,19 @@
+import {
+  ArgumentMetadata,
+  BadRequestException,
+  Injectable,
+  PipeTransform,
+} from '@nestjs/common';
+
+@Injectable()
+export class RoomCodePipe implements PipeTransform {
+  transform(value: any, _metadata: ArgumentMetadata) {
+    const hexRegExp = /^[0-9a-fA-F]{6}$/;
+
+    if (!hexRegExp.test(value)) {
+      throw new BadRequestException('Invalid room code');
+    }
+
+    return value;
+  }
+}

server/src/room/room.controller.ts

@@ -15,6 +15,7 @@ import { Request } from 'express';
 import { SessionAuthGuard } from '../auth/auth.guard';
 import User from '../entities/user.entity';
 import { RoomUserService } from '../room-user/room-user.service';
+import { RoomCodePipe } from './room-code/room-code.pipe';
 import { RoomService } from './room.service';
 
 @Controller('room')
@@ -69,4 +70,10 @@ export class RoomController {
   async getRoomUsers(@Param('code') code: string) {
     return await this.roomUserService.findUsersByRoomCode(code);
   }
+
+  @Get('/:code/rankings')
+  @HttpCode(HttpStatus.OK)
+  async getRoomRankings(@Param('code', RoomCodePipe) code: string) {
+    return await this.roomService.getRoomRankings(code);
+  }
 }

server/src/room/room.service.ts

@@ -1,17 +1,19 @@
 import {
   BadRequestException,
+  forwardRef,
   Inject,
   Injectable,
   InternalServerErrorException,
   Logger,
-  forwardRef,
 } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
 import * as crypto from 'crypto';
 import { isNil } from 'src/common/utils';
 import { SubmissionService } from 'src/submission/submission.service';
 import { Repository } from 'typeorm';
+import { Status } from '../const/boj-results';
 import Room from '../entities/room.entity';
+import Submission from '../entities/submission.entity';
 import User from '../entities/user.entity';
 import RoomUser from '../room-user/room-user.entity';
 import { RoomUserService } from '../room-user/room-user.service';
@@ -130,4 +132,36 @@ export class RoomService {
     }
     return room;
   }
+
+  /**
+   * returns an array of user id, username, and the number of accepted problems of the user, sorted by the number of accepted problems
+   * @param code
+   */
+  async getRoomRankings(code: string) {
+    Submission;
+    User;
+    const qb = this.roomRepository
+      .createQueryBuilder('room')
+      .where('room.code = :code', { code })
+      .innerJoin('room.joinedUsers', 'roomUser')
+      .innerJoin('roomUser.user', 'user')
+      .innerJoin(
+        'room.submissions',
+        'submission',
+        'submission.status = :status AND submission.user_id = user.id AND submission.alreadyAccepted = false',
+        {
+          status: Status.ACCEPTED,
+        },
+      )
+      .select('user.id', 'userId')
+      .addSelect('user.username', 'username')
+      .addSelect('COUNT(submission.id)', 'acceptedCount')
+      .addSelect('MAX(submission.submittedAt)', 'lastAcceptedAt')
+      .groupBy('user.id')
+      .orderBy('acceptedCount', 'DESC')
+      .addOrderBy('lastAcceptedAt', 'ASC');
+
+    const data = await qb.getRawMany();
+    return { data };
+  }
 }

server/src/submission/submission.service.ts

@@ -105,13 +105,23 @@ export class SubmissionService {
       status,
     );
 
+    const alreadyAccepted = await this.submissionRepository.exist({
+      where: {
+        user: { id: user.id },
+        problem: { id: problem.id },
+        room: { id: room.id },
+        status: Status.ACCEPTED,
+      },
+    });
+
     return await this.submissionRepository
       .create({
         status,
         user,
         room,
         problem,
         submittedAt,
+        alreadyAccepted,
       })
       .save();
   }