Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/userBasedRoute #268

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Refactor/userBasedRoute #268

merged 4 commits into from
Feb 14, 2024

Conversation

kiuuon
Copy link
Collaborator

@kiuuon kiuuon commented Feb 8, 2024

Description

userBasedRoute의 if문 부분을 수정했습니다.
userBasedRoute에서 setIsLoading을 이용해 AuthProvider를 업데이트해서 뜨던 경고를 해결했습니다.

@kiuuon kiuuon self-assigned this Feb 8, 2024
@kiuuon kiuuon linked an issue Feb 8, 2024 that may be closed by this pull request
1 task
Copy link
Collaborator

@vimkim vimkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(백엔드라 잘 모르지만) isNotParticipating, isParticipating 조건 두 개가 있는게 좀 헷갈렸네요! 차근차근 리팩터링 해보면 좋을 거 같습니다~

Copy link
Collaborator

@glowisn glowisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@kiuuon kiuuon merged commit 58e3705 into main Feb 14, 2024
2 checks passed
@kiuuon kiuuon deleted the refactor/user-based-route branch February 14, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: userBasedRoute 리팩토링
3 participants