Skip to content

Commit

Permalink
refactor: 버그 수정
Browse files Browse the repository at this point in the history
- 컨테이너 삭제 실패는 서버에서 핸들링하지 않는다

[#265]
  • Loading branch information
LuizyHub authored and flydog98 committed Dec 7, 2023
1 parent 5a98e59 commit 3e192fc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 1 addition & 4 deletions packages/backend/src/containers/containers.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,7 @@ export class ContainersService {
await this.commandService.executeCommand(command);

this.logger.log('info', `container deleted : ${stdoutData.trim()}`);

if (stderrData) {
throw new Error(stderrData);
}
this.logger.log('info', `container deleted error : ${stderrData.trim()}`);
}

private buildDockerCommand(container: string, ...commands: string[]): string {
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/quizzes/quizzes.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ export class QuizzesController {
return;
}

await this.containerService.deleteContainer(containerId);
this.containerService.deleteContainer(containerId);

await this.sessionService.deleteCommandHistory(sessionId, id);
} catch (e) {
Expand Down

0 comments on commit 3e192fc

Please sign in to comment.