-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] Tag e2e 테스트 작성 #384
Merged
HyoJongPark
merged 11 commits into
boostcampwm2023:develop
from
HyoJongPark:be/test/auth-tags-e2e
Feb 5, 2024
Merged
[BE] Tag e2e 테스트 작성 #384
HyoJongPark
merged 11 commits into
boostcampwm2023:develop
from
HyoJongPark:be/test/auth-tags-e2e
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyoJongPark
commented
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 짧은 코드에 하루를 쓰다니.... e2e 어렵네요...
제 임의로 jwt랑 redis 처리를 해놓았는데, 의견 있으시면 말씀해주세요!
HyoJongPark
commented
Jan 30, 2024
shunny822
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 공부하고 작성해봐야 리뷰할 수 있을 것 같아 많이 늦어졌네요😓
수고 많으셨습니다!!
shunny822
reviewed
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
#382
완료한 기능 명세
이것도 커버리지 이미지 보여드리려 했는데 심신 미약으로 나중에 해보겠습니다...
e2e테스트 할 때, OAuth 관련 의존성을 없애려고
JwtGuard
를 모킹 처리했는데 혹시 다른 의견이 있으시면 말씀해주세요!