Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] Tag e2e 테스트 작성 #384

Merged

Conversation

HyoJongPark
Copy link
Collaborator

@HyoJongPark HyoJongPark commented Jan 25, 2024

이슈 번호

#382

완료한 기능 명세

  • Tags e2e 테스트 작성
image

이것도 커버리지 이미지 보여드리려 했는데 심신 미약으로 나중에 해보겠습니다...
e2e테스트 할 때, OAuth 관련 의존성을 없애려고 JwtGuard를 모킹 처리했는데 혹시 다른 의견이 있으시면 말씀해주세요!

  • 로그인 -> 서비스 사용 까지를 구현해보는게 좋을 것 같기도 한데, 잘 모르겠네요;;

@HyoJongPark HyoJongPark added the BE 💻 BackEnd label Jan 25, 2024
@HyoJongPark HyoJongPark requested a review from shunny822 January 25, 2024 08:54
@HyoJongPark HyoJongPark self-assigned this Jan 25, 2024
Copy link
Collaborator Author

@HyoJongPark HyoJongPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 짧은 코드에 하루를 쓰다니.... e2e 어렵네요...
제 임의로 jwt랑 redis 처리를 해놓았는데, 의견 있으시면 말씀해주세요!

backend/src/tags/tags.service.ts Outdated Show resolved Hide resolved
backend/test/tags/tags.controller.e2e-spec.ts Outdated Show resolved Hide resolved
backend/test/tags/tags.controller.e2e-spec.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@shunny822 shunny822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 공부하고 작성해봐야 리뷰할 수 있을 것 같아 많이 늦어졌네요😓
수고 많으셨습니다!!

@HyoJongPark HyoJongPark merged commit e4c9dac into boostcampwm2023:develop Feb 5, 2024
1 check passed
@HyoJongPark HyoJongPark deleted the be/test/auth-tags-e2e branch February 5, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 💻 BackEnd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants