-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] Friends Module e2e 테스트 작성 #388
Merged
shunny822
merged 16 commits into
boostcampwm2023:develop
from
shunny822:be/test/friends-e2e
Feb 11, 2024
Merged
[BE] Friends Module e2e 테스트 작성 #388
shunny822
merged 16 commits into
boostcampwm2023:develop
from
shunny822:be/test/friends-e2e
Feb 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- e2e 테스트 코드 작성 - 서비스 코드에 필요한 예외처리 추가
- e2e 테스트코드 작성 - 서비스 로직에 필요한 예외처리 추가
shunny822
commented
Feb 6, 2024
shunny822
commented
Feb 6, 2024
HyoJongPark
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음! 꼼꼼하게 잘 작성하신것 같아요.! 고생하셨습니다. 😎
HyoJongPark
reviewed
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
#382
완료한 기능 명세
Friends랑 Users는 아무래도 user와 직접적인 모듈들이라 JwtAuthGuard를 모킹하지 않고 실제처럼 요청을 처리하면 좋을 것 같아 간단하게 jwt를 생성해서 쿠키에 보내는 식으로 했습니다. (이후 Users 모듈도 이렇게 할 것 같아요!)
저도 꽤 길어서 천천히 봐주세요~