get_libname: Support a list of libraries in libraries.json #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the script expects `libraries.json` to contain a dict with the library metadata. However it can contain information about multiple sub-libraries, e.g. in Boost.Utility or Boost.Functional in which case the top-level struct is a list containing a dict for each sub-library. It is also possible to wrap the single dict in a list with a single item which should be equivalent to having the dict at the top-level. Modify the script to detect such a list and work on the first entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the script expects
libraries.jsonto contain a dict with the library metadata.However it can contain information about multiple sub-libraries, e.g. in Boost.Utility or Boost.Functional in which case the top-level struct is a list containing a dict for each sub-library. It is also possible to wrap the single dict in a list with a single item which should be equivalent to having the dict at the top-level.
Modify the script to detect such a list and work on the first entry.
See boostorg/math#1061 (comment) for motivation of this change