GHA: Stop using Ubuntu 20.04 runners #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
changed the title
Flamefire
force-pushed
the
ubuntu-20
branch
2 times, most recently
from
bd0bf8b to
ad8d875
Compare
|
I can't get the sanitizer working without false positives of allocation mismatch (new vs delete) using Clang 14 on 22.04 |
Flamefire
force-pushed
the
ubuntu-20
branch
2 times, most recently
from
ebf6974 to
531da99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 22 22
Branches 10 11 +1
=========================================
Hits 22 22 Continue to review full report in Codecov by Sentry.
|
Flamefire
force-pushed
the
ubuntu-20
branch
6 times, most recently
from
0832583 to
1fc65ef
Compare
Starting brownout in February 2025
Use containers where the Clang version would conflict with libstdc++ installed on the Github runner.
Clang 13+ shows a false positive about an a new-free mismatch. Clang 12 on Ubuntu 22 is missing the libunwind-dev package. So stick to Clang 12 on Ubuntu 20.
The codecov-action must be run from the folder containing the repository as only then it can collect the files and match them against the coverage report. Actually use the environment variable $CODECOV_NAME.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/runner-images#11101