-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pre-computed constexpr Gauss and Gauss-Kronrod constants #1079
Conversation
to always store literal types. Fixes: #1077.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1079 +/- ##
===========================================
- Coverage 85.21% 84.90% -0.31%
===========================================
Files 879 880 +1
Lines 66880 67275 +395
===========================================
+ Hits 56989 57120 +131
- Misses 9891 10155 +264
Continue to review full report in Codecov by Sentry.
|
How would you feel about something like the below? I wrote a Looking at the version here I think something bad would happen across if we ran this once, cleaned up the arena, and tried running again. I'm always bad at the intricacies of static types in functions, but if they are declared once for the life of the program and we clean up the memory arena then I think the next time we run this the program would do UB accessing memory that has been cleaned up or reallocated. https://godbolt.org/z/j1br4GTno EDIT: updated link to compile with c++14 |
Also mark up anything that uses BOOST_MATH_HUGE_CONSTANT as unreachable by code coverage as gcov seems to have an issue with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments. I'm not really following how this fixes #1077
I hope this should be good to go: @SteveBronder can you try this PR against your actual code? |
Thanks I'll give this a whirl on Monday! |
This works! |
@jzmaddock : Looks like the build failure is unrelated-want to merge? |
Yup, merging... |
to always store literal types.
Fixes: #1077.