Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish instantiation runners #1096

Merged
merged 3 commits into from
Feb 17, 2024
Merged

Finish instantiation runners #1096

merged 3 commits into from
Feb 17, 2024

Conversation

ckormanyos
Copy link
Member

Fishish instantiation runner work started in #1094 and #1095

@ckormanyos ckormanyos mentioned this pull request Feb 17, 2024
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b8569c) 91.86% compared to head (b0c4224) 92.61%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1096      +/-   ##
===========================================
+ Coverage    91.86%   92.61%   +0.75%     
===========================================
  Files          769      769              
  Lines        63831    63883      +52     
===========================================
+ Hits         58637    59164     +527     
+ Misses        5194     4719     -475     
Files Coverage Δ
test/compile_test/instantiate.hpp 100.00% <100.00%> (+33.24%) ⬆️
test/test_instantiate3.cpp 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b8569c...b0c4224. Read the comment docs.

@ckormanyos ckormanyos merged commit 2a7f254 into develop Feb 17, 2024
70 checks passed
@ckormanyos ckormanyos deleted the instantiation_runners branch February 17, 2024 12:08
@ckormanyos
Copy link
Member Author

ckormanyos commented Feb 17, 2024

OK. This preliminarily wraps up the topic of getting instantiations actually running (in addition to simply compiling).

I'll probably ramp down with the trouble-making for the ramainder of the road to 1.85 (unless something broken or mysterious with my recent work comes up).

If anyone is following the action on CodeCov, we now have a solid $92{\ldots}93\%$.

Cc: @jzmaddock and @mborland and @NAThompson

@ckormanyos
Copy link
Member Author

See also #1068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant