Remove warning disable warning 4800 #841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does this change if the warnings are already suppressed? How did you generate/find these? |
AZero13
force-pushed
the
emplace
branch
2 times, most recently
from
c999d96 to
e47ecfb
Compare
|
I found these while browsing the code. It is best to get a bool directly via comparison than a conversion. It is considered to be better C++ |
We should do a comparison with 0 instead of forcing to bool
|
Without a specific bug/error/warning I am going to close this. Generally we are looking for compelling reasons to change code because of our large user base. If you are looking for ways to contribute there is a feature wishlist #303, or scan through our other open issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should do a comparison with 0 instead of forcing to bool