Adds a type-erased response adapter to the public API #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anarthal Thanks, see my comments. |
|
Did you publish your comments? I can't see any of them |
mzimbres
reviewed
Jun 9, 2024
|
Are you still going to work on this PR? |
|
whoa, I completely forgot about this! Yes, I'll finish it this incoming week. |
|
@mzimbres this is now complete on my side. Please let me know if any changes are required. |
|
Many thanks! Give me some days to review it. I would also say you this is worth listing in the Changelog. |
mzimbres
reviewed
Aug 10, 2024
mzimbres
reviewed
Aug 10, 2024
|
This is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would something along these lines suit you @mzimbres? If it does, I'll clean it up and write docs & tests for it.
close #128