Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel and eslint config #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

kimanijacky
Copy link

Update the following packages:

  • babel-preset-metalab
  • eslint-config-metalab
  • eslint
  • eslint-plugin-babel
  • eslint-plugin-filenames
  • eslint-plugin-import
  • eslint-plugin-lodash-fp
  • eslint-plugin-react

@10xjs
Copy link
Contributor

10xjs commented Mar 14, 2017

@andela-jkimani babel-preset-metalab 6 is a breaking change over 5. We need to update the .babelrc file with targets to ensure compatibility (babel-preset-metalab uses babel-preset-env internally) . See https://github.com/babel/babel-preset-env#targets.

@10xjs
Copy link
Contributor

10xjs commented Mar 14, 2017

@izaakschroeder What do you think is a sane browser target? "last 3 versions"? "last 4 versions"? ...

I assume we want to capture IE 8 and Safari 7 and whatever else.

Ideally this would be the same as what this lib currently supports, whatever that is exactly 😬 .

@izaakschroeder
Copy link
Contributor

izaakschroeder commented Mar 14, 2017

Having ["> 1%"] seems reasonable to me for now. What do you figure?

@10xjs
Copy link
Contributor

10xjs commented Mar 14, 2017

It would be nice if there was a browserslist.lock since the result of ["> 1%"] is a product of when it is calculated.

@kimanijacky
Copy link
Author

@izaakschroeder So we're not targeting specific browsers? Got it!

@kimanijacky kimanijacky force-pushed the update-babel/eslint branch 4 times, most recently from 676fa2a to e9644a9 Compare March 15, 2017 20:13
@kimanijacky kimanijacky force-pushed the update-babel/eslint branch from e9644a9 to f2d1f7e Compare March 15, 2017 20:46
@kimanijacky kimanijacky force-pushed the update-babel/eslint branch from 2186434 to 7a13a4d Compare March 15, 2017 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants