Adding Support for webclips and new codeblocks #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They could have used `<pre>`, they could have introduced an `<en-codeblock>` element. But no. They choose a custom CSS style `-en-codeblock:true`. This is obviously fragile.
Two problems: 1. distinguishing styled divs that are made by user (so may contain markdown) and the ones produced by webclips which need to be copied verbatim 2. avoid fooling markdown2 which does not tag matching to find boundaries of HTML so it gets confused with nested divs Problem 1 is solved by looking for the `-evernote-webclip` style (not documented) Problem 2 is solved by using verbatim output for webclip contents, and prepending a space to each line so that nested `</div>` are ignored.
bordaigorl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to add support for undocumented
-en-paragraph,-en-webclipand-en-codeblockstyles.This tries to address issues #184, #190, #207.
This needs testing and may break in the future (because the features it's trying to support are undocumented and subject to changes).
Any report of testing most welcome.