Fix ColmapSift unit test and update documentation

borglab · Nov 5, 2024 · 02bf2d0 · 02bf2d0
1 parent 217b05d
commit 02bf2d0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 32 deletions.
diff --git a/tests/frontend/detector_descriptor/test_colmap_sift.py b/tests/frontend/detector_descriptor/test_colmap_sift.py
@@ -18,7 +18,11 @@ class TestColmapSIFTDetectorDescriptor(test_detector_descriptor_base.TestDetecto
     def setUp(self):
         """Setup the attributes for the tests."""
         super().setUp()
-        self.detector_descriptor = ColmapSIFTDetectorDescriptor()
+        # Note: pycolmap does not guarantee that the number of keypoints will not exceed the specified maximum, as there
+        # can be ties in terms of the response scores. E.g., if the 5000th keypoint and the 5001st keypoint have the
+        # same response, pycolmap will return 5001 keypoints. Setting the number of maximum keypoints lower reduces the
+        # risk of this happening.
+        self.detector_descriptor = ColmapSIFTDetectorDescriptor(max_keypoints=2000)
 
         # explicitly set the detector
         self.detector = DetectorFromDetectorDescriptor(self.detector_descriptor)

diff --git a/tests/frontend/detector_descriptor/test_colmap_sift_detector_descriptor.py b/tests/frontend/detector_descriptor/test_colmap_sift_detector_descriptor.py