Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #703

Merged
merged 2 commits into from
Sep 2, 2023
Merged

Update README.md #703

merged 2 commits into from
Sep 2, 2023

Conversation

johnwlambert
Copy link
Collaborator

Update stale comments, as pycolmap is available for mac now: https://pypi.org/project/pycolmap/#files

Screen Shot 2023-08-31 at 11 02 15 PM

Copy link
Collaborator

@akshay-krishnan akshay-krishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we removed the --image_extension flag, could you update that in the readme too?

@akshay-krishnan
Copy link
Collaborator

has pycolmap been added to the conda env for Mac?

@johnwlambert
Copy link
Collaborator Author

has pycolmap been added to the conda env for Mac?

Yes we have added it there: https://github.com/borglab/gtsfm/blob/master/environment_mac.yml#L59

@johnwlambert
Copy link
Collaborator Author

we removed the --image_extension flag, could you update that in the readme too?

Sure, updated that now.

@johnwlambert johnwlambert merged commit 4e2fb73 into master Sep 2, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants