2 stage filtering in ViewGraphEstimator #739
Conversation
| @@ -42,6 +46,10 @@ def __init__( | |||
| self.ba_optimizer = bundle_adjustment_module | |||
| self._run_view_graph_estimator: bool = self.view_graph_estimator is not None | |||
There was a problem hiding this comment.
We should use the flag for stage 2 too?
There was a problem hiding this comment.
@ayushbaid did you mean to add the MEDIAN_EDGE_ERROR stage to the config also?
There was a problem hiding this comment.
I meant to make it optional. If we do not want to run stage 2 we can easily skip it.
But if we get good performance across the board and there is no reason to not use it, I am fine.
| viewgraph_i2Ui1_graph, | ||
| viewgraph_v_corr_idxs_graph, | ||
| viewgraph_two_view_reports_graph, | ||
| viewgraph_estimation_metrics, |
There was a problem hiding this comment.
could you save these metrics as a separate one, so we have numbers for stage1 and stage2?
There was a problem hiding this comment.
IMHO this will be overly verbose. We already get visualizations saved for each of the two stages, currently, and I think the combined performance is what matters most.
…stage-filtering
…stage-filtering
…stage-filtering
…stage-filtering
No description provided.