Add script to compare poses between two reconstructions in colmap format #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushbaid
requested review from
akshay-krishnan,
travisdriver and
johnwlambert
| """ | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument( | ||
| "--baseline", |
There was a problem hiding this comment.
could we use the term "reference" instead, if this is the target / reference?
There was a problem hiding this comment.
Technically either could the target or the source could be a baseline, though. E.g. your ground truth could be a baseline, or any method to measure against the GT could be a baseline. But 'reference' is totally unambiguous.
Baseline also can confuse me a bit in this context since it already has a specific definition within the context of SfM.
travisdriver
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked locally, pose metrics look good.