Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed i18n support to v14 one #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed i18n support to v14 one #33

wants to merge 1 commit into from

Conversation

RedGl0w
Copy link
Contributor

@RedGl0w RedGl0w commented Jul 25, 2020

boricj
boricj requested changes Jul 25, 2020
View reviewed changes
Copy link
Owner

@boricj boricj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check proprer i18n invocation bits.

Makefile
base.nl.i18n\
base.hu.i18n\
)
i18n_files += $(call i18n_with_universal_for,rpn/base)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that be i18n_without_universal_for instead?

Copy link
Contributor Author

@RedGl0w RedGl0w Jul 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I miss typed (sorry)
Going to change it tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boricj boricj boricj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RedGl0w @boricj