-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 3.9.0 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introducing UI update lock. * Using actual threading Lock. * Fix import order. * Using lock as a context manager (with). * Add logging for the lock. * Avoid calling UI update fn from the polling thread when it's already running. * Minor: comments. * Update octoprint_octorelay/__init__.py * test_input_polling__locked. * Asserting the released lock in test_update_ui.
This reverts commit e6b1aeb.
* Update CI.yaml * Update codeql.yml * Update release.yaml
* Introducing printer relay setting. * Introducing a migration. * A bit logging. * Updating the settings version test. * Fixing the condition. * Another way: common setting - printer, incl. template implementation. * Updating the bindings test. * Fix iteration in tests. * Updating snapshot. * Fixing the default scope approach in handle_plugin_event method. * Testing the migraion script. * Ref: extracting some vars in template. * Extracting one more var for shortening the expression. * Updating snapshot.
* Draft: disconnecting from the printer before when turning its relay off. * Fixing the tests. * Testing is_printer_relay() method. * Testing toggle_relay() method for the case of printer relay. * Update tests/test_init.py * Handling the case of double turned on the printer relay.
RobinTail
commented
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me
🚀 3.9.0rc1 |
✅ QA passed |
Need to update:
|
RobinTail
commented
Sep 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accumulative PR
Closes #153
Introducing UI update lock. #186