Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 3.9.0 #201

Merged
merged 11 commits into from
Sep 16, 2023
Merged

🚀 3.9.0 #201

merged 11 commits into from
Sep 16, 2023

Conversation

* Introducing UI update lock.

* Using actual threading Lock.

* Fix import order.

* Using lock as a context manager (with).

* Add logging for the lock.

* Avoid calling UI update fn from the polling thread when it's already running.

* Minor: comments.

* Update octoprint_octorelay/__init__.py

* test_input_polling__locked.

* Asserting the released lock in test_update_ui.
@RobinTail RobinTail added enhancement New feature or request release Chores for releasing new versions labels Aug 26, 2023
@coveralls
Copy link

coveralls commented Aug 26, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling 402331c on develop into 996f9ce on master.

* Update CI.yaml

* Update codeql.yml

* Update release.yaml
* Introducing printer relay setting.

* Introducing a migration.

* A bit logging.

* Updating the settings version test.

* Fixing the condition.

* Another way: common setting - printer, incl. template implementation.

* Updating the bindings test.

* Fix iteration in tests.

* Updating snapshot.

* Fixing the default scope approach in handle_plugin_event method.

* Testing the migraion script.

* Ref: extracting some vars in template.

* Extracting one more var for shortening the expression.

* Updating snapshot.
@RobinTail RobinTail changed the title 🚀 Next 🚀 3.9.0 Sep 15, 2023
* Draft: disconnecting from the printer before when turning its relay off.

* Fixing the tests.

* Testing is_printer_relay() method.

* Testing toggle_relay() method for the case of printer relay.

* Update tests/test_init.py

* Handling the case of double turned on the printer relay.
@RobinTail RobinTail marked this pull request as ready for review September 15, 2023 22:15
Copy link
Collaborator Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me

@RobinTail
Copy link
Collaborator Author

RobinTail commented Sep 15, 2023

🚀 3.9.0rc1

@RobinTail
Copy link
Collaborator Author

RobinTail commented Sep 15, 2023

✅ QA passed
works also with a postponed turning the printer relay off.

@RobinTail
Copy link
Collaborator Author

Need to update:

  • changelog
  • readme
  • screenshots

Copy link
Collaborator Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for now

@RobinTail RobinTail merged commit 1581874 into master Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request migration release Chores for releasing new versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: disconnect before turning printer relay OFF
2 participants