fix(tracing): Only override the OTEL service name if it is not already set #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y set in OTEL_RESOURCE_ATTRIBUTES or OTEL_SERVICE_NAME
timonv
requested changes
Jan 24, 2025
src/kwaak_tracing.rs
Outdated
| let resource_attributes = std::env::var("OTEL_RESOURCE_ATTRIBUTES") | ||
| .unwrap_or_default() | ||
| .split(',') | ||
| .map(|s| s.split_once("=").expect("invalid OTEL_RESOURCE_ATTRIBUTES")) |
There was a problem hiding this comment.
So if you do default (empty string), this panics.
There was a problem hiding this comment.
Eh oh no, you're not correct. We first split on , to get the pairs. So if the variable is empty, the split won't yield any results so it would never get to the resource attribute splitter.
There was a problem hiding this comment.
Hmm you actually are correct, that is surprising..
There was a problem hiding this comment.
I guess it's not really surprising, if you have a list of one element of course it would not include the separator and yield the one result.
timonv
approved these changes
Feb 7, 2025
timonv
pushed a commit
that referenced
this pull request
Feb 9, 2025
## 🤖 New release * `kwaak`: 0.8.2 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.8.2] - 2025-02-09 ### 🚀 Features - Improve line edits and add line editing evaluation (#235) - Support custom constraints for an agent (#274) - Optionally hide top header in UI (#275) ### 🐛 Bug Fixes - *(tracing)* Only override the OTEL service name if it is not already set (#224) ### ⚙️ Miscellaneous Tasks - Fmt <!-- generated by git-cliff --> </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only override the OTEL service name if it is not already set in OTEL_RESOURCE_ATTRIBUTES or OTEL_SERVICE_NAME.